Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21239
This looks pretty good to me. My only major concern is how we are enabling
it. Adding such a wide enable-all flag is to enable this is not a good idea.
Rather I would like it to be enabled surgically -
- Unsupported operation checker allows the query when there is only 1
aggregate on streaming (this does not need to change when we add
multi-partition aggregate)
- ContinuousExecution/UnsupportedOperationChecker adds one additional
check to verify whether shuffle partition is 1 (single line check, can be
deleted when we add multi-partition aggregate).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
