Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/21239#discussion_r186467958
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/ContinuousAggregationSuite.scala
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.streaming.continuous
+
+import org.apache.spark.sql.AnalysisException
+import
org.apache.spark.sql.execution.streaming.sources.ContinuousMemoryStream
+import org.apache.spark.sql.functions._
+import org.apache.spark.sql.streaming.OutputMode
+
+class ContinuousAggregationSuite extends ContinuousSuiteBase {
+ import testImplicits._
+
+ test("not enabled") {
+ val ex = intercept[AnalysisException] {
+ val input = ContinuousMemoryStream.singlePartition[Int]
+
+ testStream(input.toDF().agg(max('value)), OutputMode.Complete)(
+ AddData(input, 0, 1, 2),
+ CheckAnswer(2),
+ StopStream,
+ AddData(input, 3, 4, 5),
+ StartStream(),
+ CheckAnswer(5),
+ AddData(input, -1, -2, -3),
+ CheckAnswer(5))
+ }
+
+ assert(ex.getMessage.contains("Continuous processing does not support
Aggregate operations"))
+ }
+
+ test("basic") {
+ withSQLConf(("spark.sql.streaming.continuous.allowAllOperators",
"true")) {
--- End diff --
Supported the unsupported operation checker disabling flag as suggested by
@arunmahadevan . As mentioned in the PR description, I don't think it's worth
the effort to write these more specific checks - the current state is not
something we could meaningfully present as a complete story.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
