Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21450#discussion_r194915218
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -138,25 +139,30 @@
case RUN_EXAMPLE:
isExample = true;
+ appResource = SparkLauncher.NO_RESOURCE;
submitArgs = args.subList(1, args.size());
}
this.isExample = isExample;
- OptionParser parser = new OptionParser(true);
- parser.parse(submitArgs);
- this.requiresAppResource = parser.requiresAppResource;
+ if (!submitArgs.isEmpty()) {
--- End diff --
Do you need this check? `parser.isSpecialCommand` is initialized to
`false`, so seems like it's already handled.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
