[GitHub] spark pull request #21450: [SPARK-24319][SPARK SUBMIT] Fix spark-submit exec...

[gaborgsomogyi]

Github user gaborgsomogyi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21450#discussion_r195016532
  
    --- Diff: launcher/src/main/java/org/apache/spark/launcher/Main.java ---
    @@ -101,6 +99,22 @@ public static void main(String[] argsArray) throws 
Exception {
         }
       }
     
    +  /**
    +   * Prepare spark commands with the appropriate command builder.
    +   * If printLaunchCommand is set then the commands will be printed to the 
stderr.
    +   */
    +  private static List<String> buildCommand(AbstractCommandBuilder builder,
    --- End diff --
    
    Fixed.
    
    Just for the sake of my understanding what does `many` mean in the 
following? All?
    `For Java code, Apache Spark follows Oracle’s Java code conventions. Many 
Scala guidelines below also apply to Java.`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org