Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21649#discussion_r199328283 --- Diff: R/pkg/R/DataFrame.R --- @@ -3905,6 +3905,16 @@ setMethod("rollup", groupedData(sgd) }) +isTypeAllowedForSqlHint <- function(x) { + if (is.character(x) | is.numeric(x)) { --- End diff -- nit: very minor, both is.* returns a single element, but with `||` you get shortcut eval if is.character(x) is TRUE
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org