Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21649#discussion_r199225907
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3905,6 +3905,18 @@ setMethod("rollup",
groupedData(sgd)
})
+isTypeAllowed <- function(x) {
+ if (is.character(x)) {
+ TRUE
+ } else if (is.list(x)) {
--- End diff --
I guess we should make the nested list work, but in real usage, only one
level of list will be used in sql hint and the code will stop after checking
the first level of list.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
