Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21705#discussion_r199817343
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/ExecutorSideSQLConfSuite.scala
---
@@ -40,16 +40,24 @@ class ExecutorSideSQLConfSuite extends SparkFunSuite
with SQLTestUtils {
spark = null
}
+ private def withStaticSQLConf(pairs: (String, String)*)(f: => Unit):
Unit = {
--- End diff --
ah sorry I was wrong. Static conf is no different from normal conf, it's
just immutable during runtime. Maybe just call this method `withSQLConf`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
