Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21705#discussion_r199820857
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/internal/ExecutorSideSQLConfSuite.scala
 ---
    @@ -40,16 +40,24 @@ class ExecutorSideSQLConfSuite extends SparkFunSuite 
with SQLTestUtils {
         spark = null
       }
     
    +  private def withStaticSQLConf(pairs: (String, String)*)(f: => Unit): 
Unit = {
    --- End diff --
    
    In case of `withSQLConf`, I got an exception;
    ```
    - SPARK-24727 CODEGEN_CACHE_SIZE is correctly referenced at the executor 
side *** FAILED ***
      org.apache.spark.sql.AnalysisException: Cannot modify the value of a 
static config: spark.sql.codegen.cacheSize;
      at 
org.apache.spark.sql.catalyst.plans.PlanTestBase$$anonfun$withSQLConf$1.apply(PlanTest.scala:172)
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to