Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200236723 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -22,14 +22,17 @@ import java.lang.{Boolean => JBool} import scala.collection.mutable.ArrayBuffer import scala.language.{existentials, implicitConversions} +import org.apache.spark.sql.catalyst.trees.TreeNode import org.apache.spark.sql.types.{BooleanType, DataType} /** * Trait representing an opaque fragments of java code. */ -trait JavaCode { +trait JavaCode extends TreeNode[JavaCode] { --- End diff -- I think it is ok. Currently `ExprValue` doesn't have to be `TreeNode`.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org