Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200244308 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -291,5 +328,8 @@ class LiteralValue(val value: String, val javaType: Class[_]) extends ExprValue override def hashCode(): Int = value.hashCode() * 31 + javaType.hashCode() } +case class LiteralExpr(override val value: String, override val javaType: Class[_]) --- End diff -- do we still need this change?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org