GitHub user MrBago opened a pull request:
https://github.com/apache/spark/pull/21719
[SPARK-24747] Make Instrumentation class more flexible
## What changes were proposed in this pull request?
This PR updates the Instrumentation class to make it more flexible and a
little bit easier to use. When these APIs are merged, I'll followup with a PR
to update the training code to use these new APIs so we can remove the old
APIs. These changes are all to private APIs so this PR doesn't make any user
facing changes.
## How was this patch tested?
Existing tests.
Please review http://spark.apache.org/contributing.html before opening a
pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MrBago/spark new-instrumentation-apis
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21719.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21719
----
commit 03c9b0a9fa664171c3a6a8264fe04b3488dae4e4
Author: Bago Amirbekian <bago@...>
Date: 2018-06-25T22:52:18Z
Added Instrumentation.instrumented API with required changes to
Instrumentation class. Updated LogisticRegression to use this API as an
example.
commit 3a6537d2861c1f6dd65b717772eb4c1f2dc7c174
Author: Bago Amirbekian <bago@...>
Date: 2018-07-05T18:16:16Z
Allow `instrumented` method to return any type.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
