Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/21719#discussion_r200498732 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala --- @@ -148,12 +170,25 @@ private[spark] class Instrumentation[E <: Estimator[_]] private ( } + // TODO: Remove this (possibly replace with logModel?) /** * Logs the successful completion of the training session. */ def logSuccess(model: Model[_]): Unit = { log(s"training finished") } + + def logSuccess(): Unit = { + log("training finished") --- End diff -- We shouldn't have this `log` alias. I was wondering which log level it uses. Just use `logInfo` and remove `log(`.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org