Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21684#discussion_r200704821
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/StandaloneRestSubmitSuite.scala
---
@@ -366,7 +366,8 @@ class StandaloneRestSubmitSuite extends SparkFunSuite
with BeforeAndAfterEach {
// server explodes internally beyond recovery
// client should throw an appropriate exception to indicate server
failure
val conn3 = sendHttpRequest(statusRequestPath, "GET")
- intercept[SubmitRestProtocolException] { client.readResponse(conn3) }
// empty response
+ val response3 = client.readResponse(conn3)
--- End diff --
So here it looks like the behavior changes. Was this necessary to work
around some other test failure? if there's a way to do all this without
behavior change, all the better. I had thought it was a matter of replacing an
exception with another exception with a better error.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
