Github user rekhajoshm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21684#discussion_r200741018
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/rest/StandaloneRestSubmitSuite.scala
 ---
    @@ -366,7 +366,8 @@ class StandaloneRestSubmitSuite extends SparkFunSuite 
with BeforeAndAfterEach {
         // server explodes internally beyond recovery
         // client should throw an appropriate exception to indicate server 
failure
         val conn3 = sendHttpRequest(statusRequestPath, "GET")
    -    intercept[SubmitRestProtocolException] { client.readResponse(conn3) } 
// empty response
    +    val response3 = client.readResponse(conn3)
    --- End diff --
    
    Good point.Fixed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to