Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r200923851
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala
---
@@ -53,7 +54,30 @@ class StreamingAggregationSuite extends
StateStoreMetricsTest
import testImplicits._
- test("simple count, update mode") {
+ val confAndTestNamePostfixMatrix = List(
--- End diff --
`withSQLConf` looks like used widely between SQL unit tests, and does
additional work (SparkSession.setActiveSession), so I'm not sure it will work
technically same. Moreover, we need to run same test "multiple times", with
changing configuration.
Could you propose your code if you don't really mind? Thanks in advance!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
