Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r200932324
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala
---
@@ -53,7 +54,30 @@ class StreamingAggregationSuite extends
StateStoreMetricsTest
import testImplicits._
- test("simple count, update mode") {
+ val confAndTestNamePostfixMatrix = List(
--- End diff --
Oops. "we need to run same test "multiple times", with changing
configuration." I missed this.
We could consider like:
https://github.com/apache/spark/blob/489a5294d106130beda1509e3cbbaf707a3d703d/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala#L61-L72
e.g.,
```
StreamingAggregationSuite {
override def afterAll(): Unit = {
// false
}
override def beforeAll(): Unit = {
// false
}
}
RemoveRedundantStreamingAggregationSuite extends StreamingAggregationSuite {
override def afterAll(): Unit = {
// true
}
override def beforeAll(): Unit = {
// true
}
}
```
but I believe the current implementation works too in this case.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
