Github user mn-mikke commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21795#discussion_r203379244
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
    @@ -1147,65 +1149,66 @@ class DataFrameFunctionsSuite extends QueryTest 
with SharedSQLContext {
         val nseqi : Seq[Int] = null
         val nseqs : Seq[String] = null
         val df = Seq(
    -
           (Seq(1), Seq(2, 3), Seq(5L, 6L), nseqi, Seq("a", "b", "c"), Seq("d", 
"e"), Seq("f"), nseqs),
           (Seq(1, 0), Seq.empty[Int], Seq(2L), nseqi, Seq("a"), 
Seq.empty[String], Seq(null), nseqs)
         ).toDF("i1", "i2", "i3", "in", "s1", "s2", "s3", "sn")
     
    -    val dummyFilter = (c: Column) => c.isNull || c.isNotNull // switch 
codeGen on
    -
         // Simple test cases
    -    checkAnswer(
    --- End diff --
    
    Good catch!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to