Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/21795#discussion_r203378508
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -924,26 +926,26 @@ class DataFrameFunctionsSuite extends QueryTest with
SharedSQLContext {
null
).toDF("i")
- checkAnswer(
- idf.select(reverse('i)),
- Seq(Row(Seq(7, 8, 9, 1)), Row(Seq(2, 7, 9, 8, 5)), Row(Seq.empty),
Row(null))
- )
- checkAnswer(
- idf.filter(dummyFilter('i)).select(reverse('i)),
- Seq(Row(Seq(7, 8, 9, 1)), Row(Seq(2, 7, 9, 8, 5)), Row(Seq.empty),
Row(null))
- )
- checkAnswer(
- idf.selectExpr("reverse(i)"),
- Seq(Row(Seq(7, 8, 9, 1)), Row(Seq(2, 7, 9, 8, 5)), Row(Seq.empty),
Row(null))
- )
- checkAnswer(
- oneRowDF.selectExpr("reverse(array(1, null, 2, null))"),
- Seq(Row(Seq(null, 2, null, 1)))
- )
- checkAnswer(
- oneRowDF.filter(dummyFilter('i)).selectExpr("reverse(array(1, null,
2, null))"),
- Seq(Row(Seq(null, 2, null, 1)))
- )
+ def checkResult2(): Unit = {
--- End diff --
What about using more specific names for functions ```checkResult2```,
```checkResult3``` etc.? Maybe ```checkStringTestCases```,
```checkCasesWithArraysOfComplexTypes``` or something like that?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
