Github user MaxGekk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21439#discussion_r204231416
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
 ---
    @@ -61,6 +61,7 @@ class JacksonParser(
         dt match {
           case st: StructType => makeStructRootConverter(st)
           case mt: MapType => makeMapRootConverter(mt)
    +      case at: ArrayType => makeArrayRootConverter(at)
    --- End diff --
    
    > This change accepts the json datasource form that the master can't parse?
    
    Right, it accept arrays of any types comparing to the master which accepts 
arrays of structs only
    
    > If so, I think we need tests in JsonSuite ...
    
    I added a few tests to `JsonSuite` or do you mean some concrete test case?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to