Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21439#discussion_r204232671
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -61,6 +61,7 @@ class JacksonParser(
dt match {
case st: StructType => makeStructRootConverter(st)
case mt: MapType => makeMapRootConverter(mt)
+ case at: ArrayType => makeArrayRootConverter(at)
--- End diff --
Sorry, I didn't catch you meant specific class. Just in case, what is the
reason for adding tests to `JsonSuite`? I changed behavior of a function, so,
`JsonFunctionsSuite` is perfect place for new tests, I believe. At the moment,
you cannot specify a schema of json objects different from `StructType` in
`DataFrameReader`. In this way, the `ArrayType` can come into `JacksonParser`
only from json functions (`from_json`). I can add similar test to `JsonSuite`
as in `JsonFunctionsSuite` but it doesn't make any sense from my point of view.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
