Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21899#discussion_r206327279
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
---
@@ -118,12 +119,19 @@ case class BroadcastExchangeExec(
// SparkFatalException, which is a subclass of Exception.
ThreadUtils.awaitResult
// will catch this exception and re-throw the wrapped fatal
throwable.
case oe: OutOfMemoryError =>
- throw new SparkFatalException(
+ val sizeMessage = if (dataSize != -1) {
+ s"; Size of table is $dataSize"
--- End diff --
I think you're right @MaxGekk. I was thinking there was a MemoryManager
involved here, and you could query its size, but now I see thats only in
`HashedRelation.apply()`.
Nonetheless -- this is still useful info to include in the message, right?
It would be better if we accurately tracked the total size needed, but this is
still helpful.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
