Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21899#discussion_r206441736 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala --- @@ -118,12 +119,19 @@ case class BroadcastExchangeExec( // SparkFatalException, which is a subclass of Exception. ThreadUtils.awaitResult // will catch this exception and re-throw the wrapped fatal throwable. case oe: OutOfMemoryError => - throw new SparkFatalException( + val sizeMessage = if (dataSize != -1) { + s"; Size of table is $dataSize" --- End diff -- > this is still useful info to include in the message, right? No doubt, I would slightly improve the error message and mention that driver memory should be increased at least by `dataSize` or maybe more. And `Size of table ...` -> `Estimated size of hashed relation ...to be broadcasted`
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org