Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21860#discussion_r207475539 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala --- @@ -232,6 +232,22 @@ class WholeStageCodegenSuite extends QueryTest with SharedSQLContext { } } + ignore("SPARK-24901 check merge FastHashMap and RegularHashMap generate code max size") { --- End diff -- I see about the code size check. Would it be possible to add a test to check the result in this case or to let us know which existing test cover this case?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org