Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22009#discussion_r208336499
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2.java ---
    @@ -23,8 +23,9 @@
      * The base interface for data source v2. Implementations must have a 
public, 0-arg constructor.
      *
      * Note that this is an empty interface. Data source implementations 
should mix-in at least one of
    - * the plug-in interfaces like {@link ReadSupport} and {@link 
WriteSupport}. Otherwise it's just
    - * a dummy data source which is un-readable/writable.
    + * the read/write interfaces like {@link BatchReadSupportProvider} or
    --- End diff --
    
    I don't think this is true. Implementations don't need the providers once 
catalog integration is done.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to