Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22009#discussion_r208340913
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/BatchReadSupport.java
 ---
    @@ -0,0 +1,39 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.sources.v2.reader;
    +
    +import org.apache.spark.annotation.InterfaceStability;
    +
    +/**
    + * An interface which defines how to scan the data from data source for 
batch processing.
    + */
    +@InterfaceStability.Evolving
    +public interface BatchReadSupport extends ReadSupport {
    +
    +  /**
    +   * Returns a builder of {@link ScanConfig}. The builder can take some 
query specific information
    +   * like which operators to pushdown, and keep these information in the 
created {@link ScanConfig}.
    --- End diff --
    
    I don't think this statement is very accurate. I would not say that the 
builder is passed operators to push down because that would imply that it is 
passed `Projection` and `Filter` nodes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to