Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21889#discussion_r209527916
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTest.scala
 ---
    @@ -59,42 +59,68 @@ private[sql] trait ParquetTest extends SQLTestUtils {
       }
     
       /**
    -   * Writes `data` to a Parquet file, which is then passed to `f` and will 
be deleted after `f`
    +   * Writes `df` to a Parquet file, which is then passed to `f` and will 
be deleted after `f`
        * returns.
        */
    -  protected def withParquetFile[T <: Product: ClassTag: TypeTag]
    -      (data: Seq[T])
    +  protected def asParquetFile
    --- End diff --
    
    I would avoid unrelated refactoring and revert this back.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to