Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22101#discussion_r210043412 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/execution/RecordBinaryComparator.java --- @@ -27,7 +27,6 @@ public int compare( --- End diff -- Let us add a test suite for this function as you mentioned in the line 25. : )
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org