Github user squito commented on the issue:
https://github.com/apache/spark/pull/22101
the added tests are good. This is pretty nit-picky, but looking at the
whole test suite, are there any tests that check for anything other than the
first byte (or array length)? Seems the longer cases -- MultipleColumnRow,
MixedColumns, ArrayColumn -- fail in a very early check. NullColumn at least
checks the last column. kind of tedious test cases, but sometimes important in
these low-level things as off-by-one errors are so easy. (or maybe I just
don't properly understand these test cases ...)
anyway I don't think that needs to hold this up more, just some thoughts.
lgtm, thanks for working on this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
