Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22123#discussion_r211132019
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVDataSource.scala
 ---
    @@ -230,7 +232,7 @@ object TextInputCSVDataSource extends CSVDataSource {
             CSVDataSource.checkHeader(
    --- End diff --
    
    Can we remove `CSVDataSource.checkHeader` and switch to 
`CSVDataSource.checkHeaderColumnNames`? Looks `CSVDataSource.checkHeader` is an 
overkill and marks hard to read the code.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to