Github user koertkuipers commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22123#discussion_r211309642
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
 ---
    @@ -1603,6 +1603,39 @@ class CSVSuite extends QueryTest with 
SharedSQLContext with SQLTestUtils with Te
           .exists(msg => msg.getRenderedMessage.contains("CSV header does not 
conform to the schema")))
       }
     
    +  test("SPARK-25134: check header on parsing of dataset with projection 
and column pruning") {
    --- End diff --
    
    it seems enforceSchema always kind of "works" because it simply means it 
ignores the headers.
    what do we expect to verify in the test?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to