Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211484515
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -180,7 +180,10 @@ object UnsafeProjection
try {
GenerateUnsafeProjection.generate(unsafeExprs,
subexpressionEliminationEnabled)
} catch {
- case CodegenError(_) =>
InterpretedUnsafeProjection.createProjection(unsafeExprs)
+ case _: Exception =>
+ // We should have already see error message in `CodeGenerator`
--- End diff --
Nit: Perhaps `// the error message is already logged in CodeGenerator`? Or
`// We should have already seen the error message in CodeGenerator`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
