Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211485732
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallbackSuite.scala
---
@@ -40,4 +55,13 @@ class CodeGeneratorWithInterpretedFallbackSuite extends
SparkFunSuite with PlanT
assert(obj.isInstanceOf[InterpretedUnsafeProjection])
}
}
+
+ test("fallback to the interpreter mode") {
+ val input = Seq(IntegerType).zipWithIndex.map(x =>
BoundReference(x._2, x._1, true))
+ val fallback = CodegenObjectFactoryMode.FALLBACK.toString
+ withSQLConf(SQLConf.CODEGEN_FACTORY_MODE.key -> fallback) {
+ val obj = FailedCodegenProjection.createObject(input)
+ assert(obj.isInstanceOf[InterpretedUnsafeProjection])
--- End diff --
Should/could we also assert on the log message being printed out? Perhaps
something similar to
https://github.com/apache/spark/pull/22103/files#diff-cf187b40d98ff322d4bde4185701baa2R508
?
This is optional; the fact that we've gotten back an
`InterpretedUnsafeProjection` is a good enough indicator to me.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
