Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22168#discussion_r211577003
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -1099,7 +1111,7 @@ private class SortMergeFullOuterJoinScanner(
def advanceNext(): Boolean = {
// If we already buffered some matching rows, use them directly
- if (leftIndex <= leftMatches.size || rightIndex <= rightMatches.size) {
+ if (leftIndex <= leftMatches.length || rightIndex <=
rightMatches.length) {
--- End diff --
Why did you change size -> length?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
