Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22168#discussion_r211609440
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -1028,23 +1034,23 @@ private class SortMergeFullOuterJoinScanner(
rightIndex = 0
while (leftRowKey != null && keyOrdering.compare(leftRowKey,
matchingKey) == 0) {
- leftMatches += leftRow.copy()
+ leftMatches.add(leftRow.copy().asInstanceOf[UnsafeRow])
--- End diff --
`ExternalAppendOnlyUnsafeRowArray` will handle copy, don't need to do
another copy here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
