Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22199#discussion_r212356312
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala 
---
    @@ -338,13 +338,14 @@ private[spark] class Client(
           throw new IllegalArgumentException(s"Required executor memory 
($executorMemory" +
             s"+$executorMemoryOverhead MB) is above the max threshold ($maxMem 
MB) of this cluster! " +
             "Please check the values of 'yarn.scheduler.maximum-allocation-mb' 
and/or " +
    -        "'yarn.nodemanager.resource.memory-mb'.")
    +        "'yarn.nodemanager.resource.memory-mb and increase the memory 
appropriately.")
    --- End diff --
    
    Both settings may have to change. But your text change doesn't mention 
anything new. Why does this help? I also don't think that the current behavior 
is wrong


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to