Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22199#discussion_r212370528
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala 
---
    @@ -338,13 +338,14 @@ private[spark] class Client(
           throw new IllegalArgumentException(s"Required executor memory 
($executorMemory" +
             s"+$executorMemoryOverhead MB) is above the max threshold ($maxMem 
MB) of this cluster! " +
             "Please check the values of 'yarn.scheduler.maximum-allocation-mb' 
and/or " +
    -        "'yarn.nodemanager.resource.memory-mb'.")
    +        "'yarn.nodemanager.resource.memory-mb and increase the memory 
appropriately.")
    --- End diff --
    
    Yes both settings has to be changed, but for the AM container memory 
allocation validation only yarn.scheduler.maximum-allocation-mb parameter is 
mentioned message does not indicate to increase 
yarn.nodemanager.resource.memory-mb,  in my change i updated this message by 
including  "yarn.nodemanager.resource.memory-mb" paramter


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to