Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22197#discussion_r212812718
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
 ---
    @@ -1021,6 +1022,116 @@ class ParquetFilterSuite extends QueryTest with 
ParquetTest with SharedSQLContex
           }
         }
       }
    +
    +  test("SPARK-25207: Case-insensitive field resolution for pushdown when 
reading parquet") {
    +    val caseSensitiveParquetFilters =
    +      new ParquetFilters(conf.parquetFilterPushDownDate, 
conf.parquetFilterPushDownTimestamp,
    +        conf.parquetFilterPushDownDecimal, 
conf.parquetFilterPushDownStringStartWith,
    +        conf.parquetFilterPushDownInFilterThreshold, caseSensitive = true)
    +
    +    val caseInsensitiveParquetFilters =
    +      new ParquetFilters(conf.parquetFilterPushDownDate, 
conf.parquetFilterPushDownTimestamp,
    +        conf.parquetFilterPushDownDecimal, 
conf.parquetFilterPushDownStringStartWith,
    +        conf.parquetFilterPushDownInFilterThreshold, caseSensitive = false)
    --- End diff --
    
    nit: add a method like:
    
    ```scala
    def createParquetFilter(caseSensitive: Boolean) = {
      new ParquetFilters(conf.parquetFilterPushDownDate, 
conf.parquetFilterPushDownTimestamp,
        conf.parquetFilterPushDownDecimal, 
conf.parquetFilterPushDownStringStartWith,
        conf.parquetFilterPushDownInFilterThreshold, caseSensitive = 
caseSensitive)
    }
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to