Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22197#discussion_r212812771
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
 ---
    @@ -44,7 +45,12 @@ private[parquet] class ParquetFilters(
         pushDownTimestamp: Boolean,
         pushDownDecimal: Boolean,
         pushDownStartWith: Boolean,
    -    pushDownInFilterThreshold: Int) {
    +    pushDownInFilterThreshold: Int,
    +    caseSensitive: Boolean) {
    +
    +  private case class ParquetField(
    +      name: String,
    --- End diff --
    
    `resolvedName`? This `name` and the `name` in schema looks confused in 
following code.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to