Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22236#discussion_r212833434
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
    @@ -326,6 +330,19 @@ object FPGrowthModel extends MLReadable[FPGrowthModel] 
{
           DefaultParamsWriter.saveMetadata(instance, path, sc)
           val dataPath = new Path(path, "data").toString
           instance.freqItemsets.write.parquet(dataPath)
    +      val itemDataType = 
instance.freqItemsets.schema(instance.getItemsCol).dataType match {
    +        case ArrayType(et, _) => et
    +        case other => other // we should never get here
    --- End diff --
    
    Throw an exception then?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to