Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22236#discussion_r212936085
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/fpm/AssociationRules.scala ---
    @@ -61,6 +61,18 @@ class AssociationRules private[fpm] (
        */
       @Since("1.5.0")
       def run[Item: ClassTag](freqItemsets: RDD[FreqItemset[Item]]): 
RDD[Rule[Item]] = {
    +    run(freqItemsets, Map.empty[Item, Long])
    +  }
    +
    +  /**
    +   * Computes the association rules with confidence above `minConfidence`.
    +   * @param freqItemsets frequent itemset model obtained from [[FPGrowth]]
    +   * @return a `Set[Rule[Item]]` containing the association rules. The 
rules will be able to
    --- End diff --
    
    nice catch, thanks, I'll correct also the original one I took this from.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to