Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22162#discussion_r213026874
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -815,6 +815,24 @@ class Dataset[T] private[sql](
         println(showString(numRows, truncate, vertical))
       // scalastyle:on println
     
    +  /**
    +   * Returns the default number of rows to show when the show function is 
called without
    +   * a user specified max number of rows.
    +   * @since 2.3.0
    +   */
    +  private def numberOfRowsToShow(): Int = {
    --- End diff --
    
    we shouldn't be adding methods here


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to