Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22162#discussion_r213158056
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala 
---
    @@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest with 
SharedSQLContext {
         checkShowString(ds, expected)
       }
     
    +
    +  test("SPARK-2444git stat2 Show should follow 
spark.show.default.number.of.rows") {
    +    withSQLConf("spark.sql.show.defaultNumRows" -> "100") {
    +      val ds = (1 to 1000).toDS().as[Int].show
    --- End diff --
    
    I think its ok to check the output number of rows in show.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to