Github user NiharS commented on a diff in the pull request:
https://github.com/apache/spark/pull/22192#discussion_r213140764
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -130,6 +130,16 @@ private[spark] class Executor(
private val urlClassLoader = createClassLoader()
private val replClassLoader = addReplClassLoaderIfNeeded(urlClassLoader)
+ // One thread will handle loading all of the plugins on this executor
--- End diff --
Aside from semantics, would an `init` method be necessary instead of having
the initialization logic be in the plugin's constructor? Since the class loader
is going to call the constructor immediately, I figure having an `init`
function would only really make a difference if we want to load the plugins
right here, and then call `init` at a later point in the executor's creation. I
can't think of any particular reason why we'd want to do that, unless there's
specific executor structures that we want created prior to plugin
initialization (although in that case we could also just move the plugin
initialization further down)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
