Github user NiharS commented on a diff in the pull request:
https://github.com/apache/spark/pull/22192#discussion_r213150133
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -130,6 +130,16 @@ private[spark] class Executor(
private val urlClassLoader = createClassLoader()
private val replClassLoader = addReplClassLoaderIfNeeded(urlClassLoader)
+ // One thread will handle loading all of the plugins on this executor
--- End diff --
That does make sense. While I did say "aside from semantics", semantics is
a good reason to include it. Especially since it'll be harder to get plugin
writers to adopt an `init` function later. I'll make the other changes and make
sure the tests still pass, if anyone does feel strongly (or even weakly) on one
way over another I don't think there's much harm in either approach.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
