GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/22319

    [SPARK-25044][SQL][followup] add back UserDefinedFunction.inputTypes

    ## What changes were proposed in this pull request?
    
    This is a followup of https://github.com/apache/spark/pull/22259 .
    
    Scala case class has a wide surface: apply, accessors, copy, etc.
    
    In https://github.com/apache/spark/pull/22259 , we change the type of 
`UserDefinedFunctions.inputTypes` from `Option[Seq[DataType]]` to 
`Option[Seq[Schema]]`. This breaks backward compatibility.
    
    This PR adds back `UserDefinedFunctions.inputTypes: Option[Seq[DataType]]`, 
but does not add back the `apply` and `copy` methods, for 2 reasons.
    1. the `apply` and `copy` methods are not meant to be public to end users.
    2. Users can't call `apply` and `copy` with input types anymore. They must 
provide the nullability information to get corrected result.
    
    ## How was this patch tested?
    
    N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark revert

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22319
    
----
commit e9c6fbc1b7298d7055d91a1a118eea3abd246d27
Author: Wenchen Fan <wenchen@...>
Date:   2018-09-03T04:33:18Z

    add back UserDefinedFunction.inputTypes

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to