Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22319#discussion_r214581204 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala --- @@ -129,3 +135,11 @@ case class UserDefinedFunction protected[sql] ( } } } + +object UserDefinedFunction { + // This is to keep backward compatibility for this case class. + // TODO: revisit this case class in Spark 3.0, and narrow down the public surface. + def unapply(arg: UserDefinedFunction): Option[(AnyRef, DataType, Option[Seq[DataType]])] = { --- End diff -- Doesn't this still break binary compatibility since we bind to another signature?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org