Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r215853656 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/WideSchemaBenchmark.scala --- @@ -54,8 +54,11 @@ class WideSchemaBenchmark extends SparkFunSuite with BeforeAndAfterEach { } override def afterAll() { - super.afterAll() - out.close() + try { + super.afterAll() + } finally { + out.close() --- End diff -- Is it correct in this test suite context? We usually put `super.afterAll()` into `finally`.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org