Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22337#discussion_r215881992
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/WideSchemaBenchmark.scala
---
@@ -54,8 +54,11 @@ class WideSchemaBenchmark extends SparkFunSuite with
BeforeAndAfterEach {
}
override def afterAll() {
- super.afterAll()
- out.close()
+ try {
+ super.afterAll()
+ } finally {
+ out.close()
--- End diff --
In general, I agree with your opinion. I found some exceptional cases like
[this](https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/SchemaPruningTest.scala#L38-L44).
Thus, I keep the original order.
Should we keep the original order or try to swap them?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
