Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216882375
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
@@ -72,11 +74,7 @@ public void stop() {
@Override
public synchronized void disconnect() {
if (connection != null && connection.isOpen()) {
- try {
- connection.close();
- } catch (IOException ioe) {
- // no-op.
- }
+ IOUtils.closeQuietly(connection);
--- End diff --
I wouldn't bother with this; we don't really do it consistently, it's not a
JDK standard class, and it doesn't really save much, while adding to the
dependency on commons/io
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
