Github user Fokko commented on a diff in the pull request: https://github.com/apache/spark/pull/22399#discussion_r216922969 --- Diff: launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java --- @@ -72,11 +74,7 @@ public void stop() { @Override public synchronized void disconnect() { if (connection != null && connection.isOpen()) { - try { - connection.close(); - } catch (IOException ioe) { - // no-op. - } + IOUtils.closeQuietly(connection); --- End diff -- I wan't aware of this requirement, reverted the change.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org